tanishqgandhi1908 commented on code in PR #8890:
URL: https://github.com/apache/texera/pull/8890#discussion_r4343388935
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitAccessResource.scala:
##########
@@ -139,6 +139,7 @@ class ComputingUnitAccessResource {
computingUnitUserAccessDao
.fetchByCuid(cuid)
.asScala
+ .filterNot(access => isOwner(cuid, access.getUid))
Review Comment:
Fixed: it now loads the unit and its grants once, returns 403 unless the
caller owns the unit or holds a grant on it, and filters the owner by uid
without extra queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
