ycycse commented on code in PR #773:
URL: https://github.com/apache/tsfile/pull/773#discussion_r3068392847
##########
python/tsfile/dataset/metadata.py:
##########
@@ -148,17 +170,38 @@ def split_logical_series_path(series_path: str) ->
List[str]:
return parts
-def build_logical_series_path(table_name: str, tag_values: Iterable[Any],
field_name: str) -> str:
- components = [table_name, *tag_values, field_name]
+def build_logical_series_path(
+ table_name: str,
+ tag_values: Iterable[Any],
+ field_name: str,
+ tag_columns: Iterable[str] = (),
+) -> str:
+ components = build_logical_series_components(table_name, tag_values,
field_name, tag_columns)
return _PATH_SEPARATOR.join(_escape_path_component(component) for
component in components)
+def build_logical_series_components(
+ table_name: str,
+ tag_values: Iterable[Any],
+ field_name: str,
+ tag_columns: Iterable[str] = (),
+) -> List[str]:
+ del tag_columns
Review Comment:
This is just there to mark the parameter as intentionally unused. I agree
the current form is not clear. I will replace it with a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
