ycycse commented on code in PR #773:
URL: https://github.com/apache/tsfile/pull/773#discussion_r3068392170
##########
python/tsfile/dataset/dataframe.py:
##########
@@ -664,11 +705,26 @@ def __len__(self) -> int:
return len(self._index.series_refs_ordered)
def list_timeseries(self, path_prefix: str = "") -> List[str]:
- names = [self._build_series_name(series_ref) for series_ref in
self._index.series_refs_ordered]
if not path_prefix:
- return names
- prefix = path_prefix if path_prefix.endswith(".") else path_prefix +
"."
- return [name for name in names if name.startswith(prefix) or name ==
path_prefix]
+ return [self._build_series_name(series_ref) for series_ref in
self._index.series_refs_ordered]
+
+ try:
+ prefix_parts = split_logical_series_path(path_prefix)
+ except ValueError:
+ return []
+
+ matched = []
+ for series_ref in self._index.series_refs_ordered:
+ device_key, table_entry, field_idx =
self._get_series_components(series_ref)
+ components = build_logical_series_components(
+ table_entry.table_name,
Review Comment:
`device_key` is a `(table_name, tag_values)` tuple here, so `device_key[1]`
means the tag values. I will expand it to a named local variable to make the
code easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
