ycycse commented on code in PR #773:
URL: https://github.com/apache/tsfile/pull/773#discussion_r3068401480
##########
python/tsfile/dataset/reader.py:
##########
@@ -47,6 +47,8 @@ def _to_python_scalar(value):
def _build_exact_tag_filter(tag_values: Dict[str, object]):
tag_filter = None
for tag_column, tag_value in tag_values.items():
+ if tag_value is None:
+ continue
Review Comment:
Get. But the current native tag filter does not support `IS NULL` / `IS NOT
NULL`, and the row-based path depends on native filtering to preserve lazy
`offset/limit` reads. For now I changed this to fail fast with a clear error
instead of silently broadening the match. Proper support should be added in the
native tag filter layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
