breed commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r406984182
##########
File path: pom.xml
##########
@@ -265,15 +265,8 @@
<id>fatjar</id>
<modules>
<module>zookeeper-it</module>
- <module>zookeeper-contrib/zookeeper-contrib-fatjar</module>
Review comment:
no, i don't think fatjar should be in the zookeeper-it module. while the
fatjar does make the tests more convenient, most people using fatjars are not
running tests. (they are usually starting the server, or using it as a
convenient client.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
