ctubbsii commented on a change in pull request #1314: ZOOKEEPER-3791:
Miscellaneous Maven fixes
URL: https://github.com/apache/zookeeper/pull/1314#discussion_r407010897
##########
File path: pom.xml
##########
@@ -265,15 +265,8 @@
<id>fatjar</id>
<modules>
<module>zookeeper-it</module>
- <module>zookeeper-contrib/zookeeper-contrib-fatjar</module>
Review comment:
> i don't think fatjar should be in the zookeeper-it module
I think you may have misunderstood me. I didn't mean to suggest combining
the two modules into a single module. What I meant was combining the activation
of all the contribs into a single `full-build` profile, and not having a
separate fatjar-only profile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
