On Sat, Mar 14, 2009 at 11:52 AM, David Cournapeau <courn...@gmail.com>wrote:
> On Sun, Mar 15, 2009 at 2:40 AM, Charles R Harris > <charlesr.har...@gmail.com> wrote: > > > > > The fixes look small and I'd like them to go in. Can you put together > some > > short tests for these fixes? Would it help if you had commit privileges > in > > Numpy? > > Yes, I was about to suggest giving Josef commit access to numpy, I > unfortunately won't have much time to do anything but release tasks in > the next few days, including review. If someone else (you :) ) can > review the changes, before they go in, then there is no reason why > they can't go in - assuming they come in very soon, > The fixes are both one-liners. Testing... I wonder if tests for things like random distributions and computational accuracy of special functions shouldn't be separate scripts. They can be large file, ala special functions, or time consuming and it doesn't help that parts are needed by both scipy and numpy. I don't feel competent to say that the fixes are correct, I'll trust Josef in that regard. Chuck
_______________________________________________ Numpy-discussion mailing list Numpy-discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
