Makes sense, and a PR is a way to solicit feedback :) I'd document this for ups.conf (man page and examples), including a note that for devices which do provide a healthy LB these values may be set to 0 safely. Wondering if non-zero defaults should be there anyway. @Community, WDYT?
Also, this critical-state check should be done only when the UPS is on battery (and perhaps not calibrating), to avoid shutdowns as soon as we start after an outage :) (In a similar fashion, enterprise UPSes are known to raise an FSD to their subscribers, if manually powered on before criticality thresholds are cleared, since they can't guarantee a safe shutdown to keep data intact, if wall power gets lost again). Thanks, Jim On Wed, May 17, 2023, 10:50 Carsten Aulbert <carsten.aulb...@aei.mpg.de> wrote: > Hi all, > > On 5/16/23 20:08, Carsten Aulbert wrote: > > Idly browsing the client sources, I guess I could try to add our logic > > here[1] and use [2] to gather the battery stats from our UPS and then > > decide if this UPS is considered critical or not. But for this, I would > > need to dust off/excavate my ancient poor C knowledge ;-). > > > > I guess I will give this a try unless someone has a brilliant idea and > > could save my sanity. > > I've given it a try now and would like to get some feedback whether this > is something worth considering as a PR or if this is too niche for master: > > > https://github.com/networkupstools/nut/compare/master...carsten-AEI:nut:upsmon_low_bat_enhancement?expand=1 > > Cheers > > Carsten > > -- > Dr. Carsten Aulbert, Max Planck Institute for Gravitational Physics, > Callinstraße 38, 30167 Hannover, Germany, Phone +49 511 762 17185 > _______________________________________________ > Nut-upsuser mailing list > Nut-upsuser@alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsuser >
_______________________________________________ Nut-upsuser mailing list Nut-upsuser@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/nut-upsuser