thomasmueller commented on code in PR #2817:
URL: https://github.com/apache/jackrabbit-oak/pull/2817#discussion_r3007950085


##########
oak-search-luceneNg/README.md:
##########
@@ -0,0 +1,23 @@
+# oak-search-luceneNg
+
+Lucene 9 index provider for Oak (`type="lucene9"`).
+
+## Feature parity
+
+| Feature | Legacy Lucene | Elastic | LuceneNg |
+|---|---|---|---|
+| Property restrictions, path/type filters | ✓ | ✓ | ✓ |
+| Fulltext search | ✓ | ✓ | ✓ |
+| Facets (insecure / statistical / secure) | ✓ | ✓ | ✓ |
+| Excerpts | ✓ | ✓ | ✓ |
+| Ordering / sorting | ✓ | ✓ | ✓ |
+| Suggestions | ✓ | ✓ | ✗ |
+| Spellcheck | ✓ | ✓ | ✗ |
+| Similarity / More Like This | ✓ | ✓ (+ KNN) | ✗ |
+| Native queries | ✓ | ✓ | ✗ |
+| Index statistics / JMX | ✓ | ✓ | ✗ |
+| Index augmentors | ✓ | ✗ | ✗ |
+| NRT / hybrid indexing | ✓ | ✗ | ✗ |
+| Index copier (CopyOnRead/Write) | ✓ | ✗ | ✗ |
+| Multi-index queries | ✓ | ✗ | ✗ |

Review Comment:
   All indexes support "multi-index queries": union queries and joins can use 
multiple indexes.
   
   I think this entry refers to the "composite node store", where eg two 
repositories are used (one writeable, and one read-only, eg. only /apps + 
/libs). The regular Lucene index runs basically two queries and combines the 
result. If that's what is mean there, then I would call it "Composite queries", 
and add a remark what exactly this is.



##########
oak-search-luceneNg/README.md:
##########
@@ -0,0 +1,23 @@
+# oak-search-luceneNg
+
+Lucene 9 index provider for Oak (`type="lucene9"`).
+
+## Feature parity
+
+| Feature | Legacy Lucene | Elastic | LuceneNg |
+|---|---|---|---|
+| Property restrictions, path/type filters | ✓ | ✓ | ✓ |
+| Fulltext search | ✓ | ✓ | ✓ |
+| Facets (insecure / statistical / secure) | ✓ | ✓ | ✓ |
+| Excerpts | ✓ | ✓ | ✓ |
+| Ordering / sorting | ✓ | ✓ | ✓ |
+| Suggestions | ✓ | ✓ | ✗ |
+| Spellcheck | ✓ | ✓ | ✗ |
+| Similarity / More Like This | ✓ | ✓ (+ KNN) | ✗ |
+| Native queries | ✓ | ✓ | ✗ |
+| Index statistics / JMX | ✓ | ✓ | ✗ |
+| Index augmentors | ✓ | ✗ | ✗ |

Review Comment:
   Hm, what is this? Could you add a remark.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to