thomasmueller commented on code in PR #2817:
URL: https://github.com/apache/jackrabbit-oak/pull/2817#discussion_r3010034771
##########
pom.xml:
##########
@@ -78,6 +78,7 @@
<module>oak-segment-azure</module>
<module>oak-benchmarks</module>
<module>oak-search-elastic</module>
+ <module>oak-search-luceneNg</module>
Review Comment:
hm, the upper-case "N" breaks the naming convention... what about
"oak-search-lucene-ng" instead?
##########
oak-search-luceneNg/README.md:
##########
@@ -0,0 +1,26 @@
+# oak-search-luceneNg
+
+Lucene 9 index provider for Oak (`type="lucene9"`).
Review Comment:
What about:
```suggestion
Lucene NG index provider for Oak (`type="lucene-ng"`).
```
Hoping we can upgrade to Lucene 10 without having to change the type. I do
assume the index storage version won't change, or that there is an option to
add compatibility.
If not, and we do need to reindex for lucene 10, we can still add
"lucene-ng-10" if that should be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
