[ 
https://issues.apache.org/jira/browse/OAK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526554#comment-13526554
 ] 

Michael Dürig commented on OAK-189:
-----------------------------------

This is a consequence of the decision taken in OAK-89 to use checked exceptions 
everywhere. This inevitably leads to situations where you have to catch 
exception even though you don't want to. I think logging at debug level is the 
right thing to do. Apart from adding the stack trace to the log, I don't think 
there is any more we can do.
                
> Swallowed exceptions
> --------------------
>
>                 Key: OAK-189
>                 URL: https://issues.apache.org/jira/browse/OAK-189
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: Thomas Mueller
>
> Exceptions should not be silently swallowed. This is currently done in 
> SessionDelegate$SessionNameMapper, methods getOakPrefix(), 
> getOakPrefixFromURI(), and getJcrPrefix(). Those methods catch 
> RepositoryException, don't log by default (only when using debug level), and 
> don't log the exception stack trace or throw an exception.
> Catching a very wide band of exceptions (RepositoryException) and then simply 
> returning null is not an acceptable solution in my view.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to