[
https://issues.apache.org/jira/browse/OAK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528976#comment-13528976
]
Michael Dürig commented on OAK-189:
-----------------------------------
Thanks, this looks much better now.
The generic change I had in mind was part of the discussion around OAK-89.
There I suggested not to use checked exceptions because it would lead to
exactly this situation. I agreed to look at the respective issues on a by case
basis but remained sceptical. See
https://issues.apache.org/jira/browse/OAK-89?focusedCommentId=13270024&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13270024.
So if we want to tackle this, we will most probably have to grep through all
catch(.*) occurrences and check them manually.
> Swallowed exceptions
> --------------------
>
> Key: OAK-189
> URL: https://issues.apache.org/jira/browse/OAK-189
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Thomas Mueller
> Fix For: 0.6
>
>
> Exceptions should not be silently swallowed. This is currently done in
> SessionDelegate$SessionNameMapper, methods getOakPrefix(),
> getOakPrefixFromURI(), and getJcrPrefix(). Those methods catch
> RepositoryException, don't log by default (only when using debug level), and
> don't log the exception stack trace or throw an exception.
> Catching a very wide band of exceptions (RepositoryException) and then simply
> returning null is not an acceptable solution in my view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
