[
https://issues.apache.org/jira/browse/OAK-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528955#comment-13528955
]
Jukka Zitting commented on OAK-189:
-----------------------------------
I replaced the troublesome SessionNameMapper class with a new LocalNameMapper
one in revision 1420139. The new class doesn't use the JCR API to access the
underlying namespace registry or session-local mappings, so it doesn't need to
deal with RepositoryExceptions.
Re: 91 places; Did you have a generic design change in mind that could address
most of those, or should we look at them on a case-by-case manner like with
SessionNameMapper?
> Swallowed exceptions
> --------------------
>
> Key: OAK-189
> URL: https://issues.apache.org/jira/browse/OAK-189
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Thomas Mueller
> Fix For: 0.6
>
>
> Exceptions should not be silently swallowed. This is currently done in
> SessionDelegate$SessionNameMapper, methods getOakPrefix(),
> getOakPrefixFromURI(), and getJcrPrefix(). Those methods catch
> RepositoryException, don't log by default (only when using debug level), and
> don't log the exception stack trace or throw an exception.
> Catching a very wide band of exceptions (RepositoryException) and then simply
> returning null is not an acceptable solution in my view.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
