> On Feb. 2, 2017, 11:38 p.m., Albert Astals Cid wrote: > > i'm not sure i agree with this change, but this doesn't seem the proper way > > to do it, if we're going to continue searching anyways, don't send a > > Okular::Document::EndOfDocumentReached, just continue searching. > > Elvis Angelaccio wrote: > Should we ask input from the usability team maybe? I find the messagebox > annoying because it usually gets in the way. If I trigger Next it's because I > have not yet found what I was looking for, so I *always* click the Continue > button in the messagebox. > > Albert Astals Cid wrote: > You're reading a 20 page document, you've already read up to page 10, and > then you decide to search for "very important thing", why would you want to > wrap if you've already read the first 10 pages? > > Anyhow sure try to get someone from usability, but comparing okular to > kate is an apples to pineapples comparison imnsho.
Consider this use case: I open a pdf because I need to search something in there. Not the first time I open this pdf, so it gets open somewhere after the beginning of the document. Which means there is a good chance that I reach the end of the document without finding what I was looking for. That's why I think the "continue from beginning?" dialog can be annoying. - Elvis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/#review102350 ----------------------------------------------------------- On Feb. 9, 2017, 10:08 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129893/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 10:08 p.m.) > > > Review request for Okular, KDE Usability and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Show non-intrusive info messages whenever the search start over from the > beginning or the bottom of the document, instead of asking the user if s/he > wants to continue the search. This is consistent with search in KWrite/Kate > and with web browsers. > > > Diffs > ----- > > core/document.h 1fd86262 > core/document.cpp 41b9ddfe > ui/searchlineedit.cpp baac8be0 > > Diff: https://git.reviewboard.kde.org/r/129893/diff/ > > > Testing > ------- > > Search for something in a pdf, click Next until reaching the end of document. > Click again Next and the search starts over from the beginning of the > document, without the "Continue from the beginning?" dialog. > > > Thanks, > > Elvis Angelaccio > >
