----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ -----------------------------------------------------------
(Updated Aug. 30, 2017, 2:47 p.m.) Review request for Okular, KDE Usability and Albert Astals Cid. Changes ------- Simpler diff. It still uses EndOfDocumentReached but at least it doesn't add new values to SearchType. Repository: okular Description ------- Show non-intrusive info messages whenever the search start over from the beginning or the bottom of the document, instead of asking the user if s/he wants to continue the search. This is consistent with search in KWrite/Kate and with web browsers. Diffs (updated) ----- core/document.cpp b725ecfc7 ui/searchlineedit.cpp 74e6ef60c Diff: https://git.reviewboard.kde.org/r/129893/diff/ Testing ------- Search for something in a pdf, click Next until reaching the end of document. Click again Next and the search starts over from the beginning of the document, without the "Continue from the beginning?" dialog. File Attachments ---------------- Before: dialog asks if the search should continue from the beginning. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/16eca574-0572-455d-babe-54f1087a403f__before.png After: always continue search from beginning, with a non-intrusive notification. https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/23b69d9a-6fbf-45a5-9595-d355dac26042__after.png Thanks, Elvis Angelaccio
