-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3143/
-----------------------------------------------------------

(Updated 2011-12-12 18:23:46.548715)


Review request for oozie, Mohammad Islam and Angelo K. Huang.


Summary
-------

a) Separate classes for different types of actions
   ------------------------------------------------
   The different types of actions like FS actions, HCat related actions, etc. 
can be grouped together in separate classes like FSActions, HCatActions, etc.

b) Passing the prepare logic to the Launcher
   -----------------------------------------
   Launcher needs the Prepare XML block to execute the actions. Oozie server 
can write the XML block to a file on DFS and then the Launcher could read from 
there.

c) Execution of actions through a "Driver"
   ---------------------------------------
   The Launcher can pass the XML block to the Driver which parses the content 
and calls corresponding methods that are grouped in different classes.


This addresses bug OOZIE-616.
    https://issues.apache.org/jira/browse/OOZIE-616


Diffs (updated)
-----

  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FileSystemActions.java 
PRE-CREATION 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
1211045 
  trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
1211045 
  
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java
 PRE-CREATION 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java
 PRE-CREATION 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java
 1211045 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 
1211045 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java
 1211045 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java
 1211045 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java
 1211045 
  
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/3143/diff


Testing
-------

Yes


Thanks,

Kiran

Reply via email to