----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3143/#review4939 -----------------------------------------------------------
All related testcases are failing after applying the patch to trunk: Running org.apache.oozie.action.hadoop.TestJavaActionExecutor Tests run: 14, Failures: 6, Errors: 0, Skipped: 0, Time elapsed: 211.483 sec <<< FAILURE! Running org.apache.oozie.action.hadoop.TestLauncher Tests run: 9, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 169.621 sec <<< FAILURE! Running org.apache.oozie.action.hadoop.TestMapReduceActionError Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 23.445 sec <<< FAILURE! Running org.apache.oozie.action.hadoop.TestMapReduceActionExecutor Tests run: 8, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 117.263 sec <<< FAILURE! Running org.apache.oozie.action.hadoop.TestPigActionExecutor Tests run: 9, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 185.404 sec <<< FAILURE! Running org.apache.oozie.action.hadoop.TestPrepareActionsDriver Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.791 sec Running org.apache.oozie.action.hadoop.TestShellActionExecutor Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 75.039 sec <<< FAILURE! Results : Failed tests: testSimpestSleSubmitOK(org.apache.oozie.action.hadoop.TestJavaActionExecutor) testOutputSubmitOK(org.apache.oozie.action.hadoop.TestJavaActionExecutor) testAdditionalJarSubmitOK(org.apache.oozie.action.hadoop.TestJavaActionExecutor) testExit0SubmitOK(org.apache.oozie.action.hadoop.TestJavaActionExecutor) testExit1SubmitError(org.apache.oozie.action.hadoop.TestJavaActionExecutor) testRecovery(org.apache.oozie.action.hadoop.TestJavaActionExecutor) testEmpty(org.apache.oozie.action.hadoop.TestLauncher) testExit0(org.apache.oozie.action.hadoop.TestLauncher) testOutput(org.apache.oozie.action.hadoop.TestLauncher) testNewId(org.apache.oozie.action.hadoop.TestLauncher) testSecurityManager(org.apache.oozie.action.hadoop.TestLauncher) testMapReduce(org.apache.oozie.action.hadoop.TestMapReduceActionError) testMapReduce(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) testMapReduceWithCredentials(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) testStreaming(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) testSetExecutionStats_when_user_has_specified_stats_write_TRUE(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) testSetExecutionStats_when_user_has_specified_stats_write_FALSE(org.apache.oozie.action.hadoop.TestMapReduceActionExecutor) testExecutionStats(org.apache.oozie.action.hadoop.TestPigActionExecutor) testExternalChildIds(org.apache.oozie.action.hadoop.TestPigActionExecutor) testExecutionStatsWithRetrieveStatsFalse(org.apache.oozie.action.hadoop.TestPigActionExecutor) testPig(org.apache.oozie.action.hadoop.TestPigActionExecutor) testUdfPig(org.apache.oozie.action.hadoop.TestPigActionExecutor) testShellScript(org.apache.oozie.action.hadoop.TestShellActionExecutor) testPerlScript(org.apache.oozie.action.hadoop.TestShellActionExecutor) Tests run: 50, Failures: 24, Errors: 0, Skipped: 0 - Alejandro On 2012-02-08 21:06:03, Kiran Nagasubramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3143/ > ----------------------------------------------------------- > > (Updated 2012-02-08 21:06:03) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > a) Separate classes for different types of actions > ------------------------------------------------ > The different types of actions like FS actions, HCat related actions, etc. > can be grouped together in separate classes like FSActions, HCatActions, etc. > > b) Passing the prepare logic to the Launcher > ----------------------------------------- > Launcher needs the Prepare XML block to execute the actions. Oozie server > can write the XML block to a file on DFS and then the Launcher could read > from there. > > c) Execution of actions through a "Driver" > --------------------------------------- > The Launcher can pass the XML block to the Driver which parses the content > and calls corresponding methods that are grouped in different classes. > > > This addresses bug OOZIE-616. > https://issues.apache.org/jira/browse/OOZIE-616 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FileSystemActions.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1213901 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1213901 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1213901 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1213901 > > Diff: https://reviews.apache.org/r/3143/diff > > > Testing > ------- > > Yes > > > Thanks, > > Kiran > >
