----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3143/#review3952 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3143/#comment8923> we should print/propagate the exception, else the root cause is lost and we won't know why is failing - Alejandro On 2011-12-16 19:34:53, Kiran Nagasubramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3143/ > ----------------------------------------------------------- > > (Updated 2011-12-16 19:34:53) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > a) Separate classes for different types of actions > ------------------------------------------------ > The different types of actions like FS actions, HCat related actions, etc. > can be grouped together in separate classes like FSActions, HCatActions, etc. > > b) Passing the prepare logic to the Launcher > ----------------------------------------- > Launcher needs the Prepare XML block to execute the actions. Oozie server > can write the XML block to a file on DFS and then the Launcher could read > from there. > > c) Execution of actions through a "Driver" > --------------------------------------- > The Launcher can pass the XML block to the Driver which parses the content > and calls corresponding methods that are grouped in different classes. > > > This addresses bug OOZIE-616. > https://issues.apache.org/jira/browse/OOZIE-616 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FileSystemActions.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1213901 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1213901 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1213901 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1213901 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1213901 > > Diff: https://reviews.apache.org/r/3143/diff > > > Testing > ------- > > Yes > > > Thanks, > > Kiran > >
