It's easy to fix the _subdir bug. The key question is how we can add testing 
(e.g., with AppVeyor) to make sure this doesn't regress again.

Should we have some sort of test for, e.g., accessing element.txt and returning 
FAIL if it defaults to compiled data?

Thanks,
-Geoff

> BABEL_DATADIR is absent on windows and data files are placed in "bin/data" 
> path. A commit some time ago 
> (https://github.com/openbabel/openbabel/commit/a45a046ff283f79e0f6423408578792e16c80727
>  
> <https://github.com/openbabel/openbabel/commit/a45a046ff283f79e0f6423408578792e16c80727>)
>  has a regression where "_subdir" param is not even checked which eventually 
> broke the support of the "bin/data" lookup. Where should I put them? I've 
> tried few directories which are obvious choices but with no luck:



------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

Reply via email to