Hi Dave... On 9/2/06, David Blevins <[EMAIL PROTECTED]> wrote:
Excellent work Mohammad! I applied an updated version of the patch which contains the modifications I mentioned before. I went ahead and assigned you OPENEJB-147 and OPENEJB-172. Will take a look at that email you mention. It's so great to have your help! Thank you!
You are so welcome :) -David
On Sep 2, 2006, at 4:32 AM, Mohammad Nour El-Din wrote: > Hi Dave... > > Sorry for being late to reply, I added the missing files and made the > changes you asked for. > Here is the new patch http://jira.codehaus.org/browse/OPENEJB-146. > I will > work on *OPENEJB-147* & *OPENEJB-172*, please assign them to me. > One more > favor, please take a look at this mail > http://marc.theaimsgroup.com/?l=openejb- > development&m=115699229501566&w=2 . > > Thanks and best regards... > Mohammad Nour El-Din > > > On 8/31/06, David Blevins <[EMAIL PROTECTED]> wrote: > >> Hi Mohammad! >> >> On Aug 30, 2006, at 8:12 PM, Mohammad Nour El-Din wrote: >> >> > Hi Dave... >> > >> > I have submited the patch of OPENEJB-146, please review and assign >> > to me >> > OPENEJB-147 :) >> >> Excellent! I reviewed the patch and have a couple of notes: >> >> The first is simple, you forgot to 'svn add' the component local >> interfaces :) >> >> Also, go ahead and put the local interfaces on the >> BasicStatelessPojoBean that we created in the last set of tests. No >> need to add inheritance and copy the bean def in the descriptors. My >> original note in that jira was actually about splitting the component >> local and business local interface tests into two beans, but we don't >> need to do that for the component remote and the component local >> tests. >> >> Looking great! You're starting to cook :) >> >> -David >> >> > Thanks and best regards... >> > Mohammad Nour El-Din >> > >> > >> > On 8/30/06, Mohammed Nour < [EMAIL PROTECTED]> wrote: >> > >> >> Hi Daves... >> >> >> >> On 8/30/06, David Blevins <[EMAIL PROTECTED]> wrote: >> >> > >> >> > Hi Mohammads... :) >> >> > >> >> > Now that's a big sentence! Edgar Allan Poe would be jealous. >> >> > >> >> > Comments below. >> >> > >> >> > On Aug 29, 2006, at 3:11 PM, Mohammed Nour wrote: >> >> > >> >> > > Hi Daves... >> >> > > >> >> > > Sure you can assign it to me, it will be my honor and >> >> pleasure :), >> >> > > but - >> >> > > correct me if I am wrong - I have noticed that there is no >> iTests >> >> > > for using >> >> > > local interfaces, so I have some simple re-factoring ideas >> so we >> >> > > can make >> >> > > iTests for using local interfaces, I am working on them and >> will >> >> > > send you a >> >> > > patch, this of caurse will include the re-factored impl of the >> >> two >> >> > > iTests >> >> > > that you and me did. >> >> > >> >> > Ok. I updated OPENEJB-146 "iTest: StatelessLocalJndiTests" so >> >> it no >> >> > longer includes testing the local business interface -- probably >> >> > should have been that way from the beginning. >> >> > >> >> > I'll leave 146 assigned to you until I hear otherwise. >> >> > >> >> > The tests OPENEJB-145 and OPENEJB-171 don't need to be >> updated as >> >> > they intentionally are only for remote interfaces. Unless >> when you >> >> > say "refactor" you mean you simply adding a local and local-home >> >> > interfaces to the POJOs we created. That would be fine. >> >> > >> >> > > I want to ask you a favor, can I have a JIRA of a >> >> > > feature to impl beside the iTests, if it is OK with you I will >> >> be very >> >> > > happy, but if u see that I rush to have more tasks so I will >> >> stick >> >> > > with the >> >> > > iTests till I finish them all and then go into new features >> >> JIRAs. >> >> > >> >> > You can work on whatever you think you can do. I personally >> don't >> >> > take more than one or two at a time cause I just can't do >> more than >> >> > one or two at a time. I'd love to do them all. >> >> >> >> >> >> Thanks for the advice, and I will stick with it :) >> >> >> >> -David >> >> > >> >> > > Thanks and best regards... >> >> > > Mohammad Nour El-Din >> >> > > >> >> > > >> >> > > On 8/29/06, David Blevins < [EMAIL PROTECTED]> wrote: >> >> > > >> >> > >> Great patch, Mohammad. It applied, built and ran perfectly. >> >> > >> >> >> > >> Regarding OPENEJB-146, as I've said here (http:// >> >> > >> marc.theaimsgroup.com/?l=openejb- >> >> development&m=115561420703000&w=2) >> >> > >> doing that one requires a whole bunch of functionality we >> >> don't have >> >> > >> yet, so there are probably better jiras to work on. >> >> > >> >> >> > >> OPENEJB-147 would be a good one. That will be easier than >> >> the one >> >> > >> you just did as you won't even have to create a new bean and >> >> add it >> >> > >> to the various deployment descriptors. >> >> > >> >> >> > >> Let me know and I'll assign it to you. >> >> > >> >> >> > >> Thanks! >> >> > >> David >> >> > >> >> >> > >> >> >> > >> On Aug 27, 2006, at 5:12 AM, Mohammed Nour wrote: >> >> > >> >> >> > >> > Hi Daves... >> >> > >> > >> >> > >> > I attached the new diff file to OPENEJB-171, I will work on >> >> > >> > OPENEJB-146 with >> >> > >> > the same procedure. >> >> > >> > >> >> > >> > Thanks and best regards... >> >> > >> > Mohammad Nour El-Din >> >> > >> > >> >> > >> > >> >> > >> > On 8/27/06, David Blevins <[EMAIL PROTECTED] > wrote: >> >> > >> > >> >> > >> >> On Aug 26, 2006, at 1:31 PM, David Blevins wrote: >> >> > >> >> > I'll take a look at this and get back to you later >> today. >> >> > >> >> >> >> > >> >> The patch looks good, you're just missing a few files. >> >> Not a big >> >> > >> >> deal, you just need to 'svn add' them so svn will include >> >> them >> >> > >> in the >> >> > >> >> patch. Give that a try and attach a new patch file here: >> >> http:// >> >> > >> >> jira.codehaus.org/browse/OPENEJB-171 >> >> > >> >> >> >> > >> >> > On Aug 26, 2006, at 10:59 AM, Mohammed Nour wrote: >> >> > >> >> > >> >> > >> >> >> Hi Daves... >> >> > >> >> >> I followed the steps you explained to me, but I have a >> >> > >> couple of >> >> > >> >> >> stupid questions :) : >> >> > >> >> >> I don't see any thing the build output which indicates >> >> that the >> >> > >> >> >> test case was running, why? >> >> > >> >> >> >> > >> >> It's just the way the surefire plugin works. It only >> >> displays the >> >> > >> >> names of the tests that are in that module and we have all >> >> the >> >> > >> itests >> >> > >> >> in another module. If it fails though, there will be a >> >> report >> >> > >> under >> >> > >> >> openejb-core/target/surefire-reports/ >> >> > >> >> >> >> > >> >> >> What is the use of spring.xml, is it for assembling the >> >> > >> components >> >> > >> >> >> of the EJB container? If yes, do I have to read about >> >> spring to >> >> > >> >> > >> >> >> know the details of this XML file ? >> >> > >> >> >> >> > >> >> Yes, and it's experimental. You don't need to understand >> >> it to >> >> > >> work >> >> > >> >> on OpenEJB. You'll need to add OpenEJB deployments to it >> >> whenever >> >> > >> >> > >> >> you add them to the ejb-jar.xml, but we can help with that >> >> if the >> >> > >> >> need comes up again. >> >> > >> >> >> >> > >> >> -David >> >> > >> >> >> >> > >> >> >> >> > >> >> >> > >> >> >> > >> >> > >> >> >> >> >> >>
