On Dec 13, 2006, at 9:44 PM, David Blevins wrote:

All,

The release is cut and awaiting your vote! All the files are available in a staging area in my home dir on people.

http://people.apache.org/~dblevins/stage/org/apache/openejb/

   itests-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}
   modules-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}
   openejb-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}
   openejb-axis-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}
openejb-builder-2.2-incubating (jar,source,javadoc,pom) {asc,md4,sha1}
   openejb-corba-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}
openejb-corba-builder-2.2-incubating (jar,source,javadoc,pom) {asc,md4,sha1}
   openejb-core-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}
openejb-itests-core-2.2-incubating (jar,source,javadoc,pom) {asc,md4,sha1} openejb-pkgen-builder-2.2-incubating (jar,source,javadoc,pom) {asc,md4,sha1}
   openejb-yoko-2.2-incubating (jar,source,javadoc,pom){asc,md4,sha1}

Here are my initial comments. Most are probably style issues. Not necessarily show-stoppers... I'll take a look at the contents later this morning...

1) the source distributions cannot build -- there's no pom.xml. I think most people (reviewers) would expect a source archive to contain a buildable unit. To be able to build I think I'd need to download the individual poms + the root pom. 2) the source distributions don't unpack in to a resource specific directory. jar xvf openejb-core-2.2-incubating-sources.jar goes directly into org/apache/openejb, not openejb-core/src/main/java/...

Personally, I'd prefer to see a single source distribution (the equivalent of svn export http://svn.apache.org/repos/asf/incubator/ openejb/tags/openejb-2.2/) and a single binary distribution. Or a single source distribution + the individual binary jars. I think a single source distribution is kind of important -- I frequently download the source distributions of projects. I expect them to be complete. It's a pain to have to download multiple source archives. Few people will download the binary/binaries -- target audience for a single binary is for your reviewers... ;-)

Has anyone verified the digital signatures of every archive? Each asc,md4,sha1 should be validated. At least one project member should double-check them all...

--kevan

Reply via email to