The only additional comments I have are couple typos and a white-space
issue:
1. There is a typo in the Copyright year (201 rather than 2018) in the
following two files:
modules/javafx.base/src/main/java/com/sun/javafx/collections/SetListenerHelper.java
modules/javafx.graphics/src/main/java/javafx/scene/Scene.java
2. There are tab characters in the following file that need to be
changed to spaces:
modules/javafx.base/src/test/java/test/com/sun/javafx/binding/SelectBindingTest.java
public static void setUpClass() {
>>> System.err.println("SelectBindingTest : log messages are
expected from these tests.");
All my testing looks good. With this patch I am now able to run
applications with OpenJDK 10 + a standalone FX SDK with no qualified
exports on the command line (as long as it doesn't use Swing interop).
-- Kevin
Ajit Ghaisas wrote:
Hi Kevin, Mandy and Daniel,
Please review the changeset that removes dependency on sun.util.logging
package from JavaFX code.
Bug : https://bugs.openjdk.java.net/browse/JDK-8195799
Fix : http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.0/
Request you to review.
Regards,
Ajit
