On Wed, 11 Dec 2019 01:04:15 GMT, Scott Palmer <swpal...@openjdk.org> wrote:
>> As a follow-on point to the missing public method in TextFlow, can you add >> unit tests for the API methods on both `Text` and `TextFlow`? A good way to >> do that is to have a test for all combinations of setting the value via the >> setter and the property method, and getting the value via the getter and the >> property method. > > The unit tests that were already added to `TextTest.java` cover the new > methods on Text, but not in every combination. I'll add a couple more to > ensure all combinations are covered. `TextFlow` has no existing unit tests > that I could find! Shall I add a new `TextFlowText.java` file for just these > tests? > > The apps/toys folder seems to use ant-based projects. The existing ones > don't build for me. If I made a new project there could I use the JavaFX > Gradle plugin and configure it to get JavaFX from the build/sdk folder? I think a new `TextFlowTest.java` would be a good place for those tests. Our build is set up to use `ant` so if you want to wire it up to the build, you'll need that (it should be as simple as having `ANT_HOME` set to `apache-ant-1.10.5`). It would be fine to defer this if you can't get it working. ------------- PR: https://git.openjdk.java.net/jfx/pull/32
