On Thu, 12 Dec 2019 15:15:38 GMT, Scott Palmer <swpal...@openjdk.org> wrote:

>> I think a new `TextFlowTest.java` would be a good place for those tests.
>> 
>> Our build is set up to use `ant` so if you want to wire it up to the build, 
>> you'll need that (it should be as simple as having `ANT_HOME` set to 
>> `apache-ant-1.10.5`). It would be fine to defer this if you can't get it 
>> working.
> 
> I just noticed while updating the CSR that, while I mentioned it on the 
> mailing list, the fact that TextFlow's tabSize override that of any contained 
> Text nodes is not documented.
> Shall I add to the javadoc for tabSize  in TextFlow : "This value overrides 
> the tabSize of contained Text nodes." ?

Good catch. Yes, please update it as you suggested.

-------------

PR: https://git.openjdk.java.net/jfx/pull/32

Reply via email to