On Thu, 16 Jan 2020 11:28:21 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit. > > The fix itself looks good and seems safe for 14. > I do have few minor changes in test file and suggestions in fix code, please > take a look. > Also verified that large sized snapshots are created correctly. > > > Upon closer inspection, I believe that the tests I added in Snapshot3Test are > indeed redundant and less complete than the 4 ignored test in Snapshot2Test. > I therefore propose to remove Snapshot3Test.java entirely and to re-enable > the 4 testSnapshotBig* test instead. I did miss this comment, The test in `Snapshot2Test` look sufficient and you can get rid of `Snapshot3Test.java` and so all my comments :) ------------- PR: https://git.openjdk.java.net/jfx/pull/68
