On Thu, 16 Jan 2020 13:56:44 GMT, Frederic Thevenet <github.com+7450507+ftheve...@openjdk.org> wrote:
>> I think the proposed code changes are wrong in case that `height / >> maxTextureSize` is an exact integer. (Same for width). I normally add the 1 >> only if `height % maxTextureSize != 0` > > Indeed, substituting the floating math for integer math requires an extra > test on the remainder to be correct. > Since this code isn't located in a tight loop, I'm not sure this optimization > is worth making the code less straight forward. What do you all think? I think it is not worth it. ------------- PR: https://git.openjdk.java.net/jfx/pull/68
