On Fri, 28 Feb 2020 08:03:45 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> I finished my review and tested this on all platforms. It looks good to me. >> >> The only comment I have is the one inline comment I left in >> `KeyCodeMap.java` about renaming the "put" method to something with "entry" >> in the name to reflect what it now does. > >> The only comment I have is the one inline comment I left in KeyCodeMap.java >> about renaming the "put" method to something with "entry" in the name to >> reflect what it now does. > > Will fix it after Ambarish reviews. The fix looks good to me too, Shall approve once PR is updated for Kevin's comment. ------------- PR: https://git.openjdk.java.net/jfx/pull/104
