On Thu, 12 Mar 2020 12:39:16 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   extra space removed
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewHorizontalArrowsTest.java
>  line 122:
> 
>> 121:     }
>> 122:
>> 123:     /**
> 
> changing the parameter of the test is at least unusual, should be doc'ed so 
> future contributors are aware of it

Good catch!!!
It definitely would have unintentional side effect of incorrect orientation in 
subsequent tests.
I updated the test to restore the orientation at the end of the test. Also 
documented the same.

-------------

PR: https://git.openjdk.java.net/jfx/pull/114

Reply via email to