On Fri, 25 Sep 2020 11:19:39 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> @kevinrushforth >> I don't know how to avoid the jcheck error, but what can I do? >> yosbits is Naohiro Yoshimoto. > > beware: all listeners that are manually added by the skin (as opposed to > those added via skin.registerXX) must be > manually removed again! Also there must be tests added to guard against > memory leaks and side-effects when switching > the skin. For guidance, see > [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364) and related > (fixed and > open) issues. @kleopatra It's a very good point, but the original source code seems to have a memory leak problem due to an incomplete implementation of dispose (). Checking with the profile tool, it looks like you need a cleanup of over 20 references. I think this is a problem that should be fixed in another issue. ------------- PR: https://git.openjdk.java.net/jfx/pull/307
