On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264127: > Added checks, whether the correction ammount of editStart/cancel events are > triggered > > > curious: do you understand the dependency of update sequence (updateEditing > relative to updateFocus)? > > [... ] > > * `focusIndex == editingIndex` and calling updateEditing after > updateFocus - all offEditing transitions are failing due to corrupting list > editing state > > > TableCell does the latter and has no dependency on focus state - at least > none I can see ;) actually, TableCell behavior only _appears_ to not depend on focus state .. because the cell is never moved into focused state if its TableRow is null ;) With a setup including updateTableRow, its focused state is updated to false when moving off the editing row which triggers the listener in cell which cancels the edit ... so we basically have the same behavior as in ListCell. To keep the tests focused on editing (vs a mix-in of other properties), we should probably (?) setup focus to -1 always. ------------- PR: https://git.openjdk.java.net/jfx/pull/441
