On Wed, 14 Apr 2021 11:58:14 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Fixing ListCell editing status is true, when index changes while editing. > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264127: > Added checks, whether the correction ammount of editStart/cancel events are > triggered Finally found time to update the PR. 1. As suggested, I've moved the updateIndex method below the if. 2. The test from 1 to -1 is a bit more complicated. Because -1 represents "not editing" the test would be differnt. I've adapted the test to check for "not editing" in the case of -1. With this change the test is green. Honestly im not really aware of the Ordering of the methods. I didn't spend a lot of time understanding the inner works of all the controls - im usually more focused on fixing memory leaks. About the initial focus, i see 3 options: - set it to -1 in testChangeIndexToEditing1_jdk_8264127 - set it to -1 in assertChangeIndexToEditing - set it to -1 in the setup method. All 3 options work. Im fine with keeping it at the concrete test, because it's the only test who needs it, but im fine with any of the 3 options. ------------- PR: https://git.openjdk.java.net/jfx/pull/441
