On Mon, 15 Mar 2021 09:11:41 GMT, Robert Lichtenberger <rlich...@openjdk.org> 
wrote:

>> Reverting to the old way of showing the context menu but with application
>> of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct
>> size measurement of the menu.
>
> Yes I can try to look into this.
> 
> On 3/12/21 2:59 PM, Kevin Rushforth wrote:
>>
>> This fixes the bug in question, although I see a slight regression in 
>> behavior on Windows with 125% pixel scaling (it doesn't reproduce with 
>> any other scaling value that I tried). With the original test case for 
>> JDK-8228363 <https://bugs.openjdk.java.net/browse/JDK-8228363>, and 
>> |TOP| as the value of |side|, the initial menu is positioned slightly 
>> lower (by a few pixels) than it should be. See the attached image. It 
>> is correct the second and subsequent times the context menu is opened.
>>
>> Given that this new bug only happens with 125% scaling, it seems 
>> likely that it is a preexisting bug, and this fix merely exposes it. 
>> Can you take a look at this? If it is preexisting, then we should file 
>> a follow-on bug for this.
>>
>> ContextMenu-125 
>> <https://user-images.githubusercontent.com/34689748/110947924-9991ce00-82f5-11eb-82d2-6959ef24293f.png>
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub 
>> <https://github.com/openjdk/jfx/pull/410#issuecomment-797506928>, or 
>> unsubscribe 
>> <https://github.com/notifications/unsubscribe-auth/ABCKAQ667DN5I4VPLF37ACTTDIF23ANCNFSM4YCWEUJQ>.
>>

> @effad have you had a chance to look at the rendering issues with 125% HiDPI 
> scaling?

Unfortunately no, not yet. I had some troubles setting up the Windows build and 
a lot of other stuff to do.
But I will try to get things going this wednesday.

-------------

PR: https://git.openjdk.java.net/jfx/pull/410

Reply via email to