On Thu, 8 Jul 2021 10:19:54 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Hmm ... wondering whether we really want to widen the scope of this issue >> >> - it started with being focused on NPE on the change of property value, for >> both Choice/ComboBox >> - turned out combo's skin also has a throwing listener to value >> - review spotted an additional failure candidates in ComboBox' editable >> property >> - plus a sore spot in combo's skin (one of the locations where list/combo >> selection is sync'ed, there are others ;) >> >> the first two are naturally within the original scope, the third is near >> enough (a property on one of the covered controls) to be included .. the >> last is arguable, IMO - would tend to not include it here but open a >> follow-up to then include _all_ sync issues in the skin (probably needs more >> digging and definitely more testing). >> >> Thoughts? > > hmm ... can't unresolve this (probably because I wasn't involved?) - how to > make it part of the review? hmm .. looks like I can only add comments to a review when being on the "files changed" tab, but not on the "Conversation" tab? *dooh .. what a ux ;) Hope my comment above is visible to all .. ------------- PR: https://git.openjdk.java.net/jfx/pull/557
