On Thu, 8 Jul 2021 21:04:44 GMT, Marius Hanl <[email protected]> wrote:
>
>
> Hmm, but leaving a test without an assert is also bad. You have any
> suggestions?
Not aware of such a rule - if we fix code throwing an exception there is not
much to assert, except that it fails before and passes after. And paddling back
a bit, I think a separate test for the back switch would be overdoing it :)
@Test
...
// configure: just as you do
comboBox.setEditable(true)
...
// the test: just as you do - switch to false
comboBox.setEditable(false)
// safe-guard against future implementation changes: switch back to
true
comboBox.setEditable(true)
// end of test
-------------
PR: https://git.openjdk.java.net/jfx/pull/557
