On Fri, 29 Oct 2021 11:23:50 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed isExtendedMnemonic check from isSimpleMnemonic > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java > line 238: > >> 236: } >> 237: >> 238: return !isExtendedMnemonic(s, position); > > I am not sure why do we need to check for isExtendedMnemonic() inside > isSimpleMnemonic() implementation. > These two methods should be separate and it is up to the callers to check and > take appropriate action. Done. ------------- PR: https://git.openjdk.java.net/jfx/pull/647
