On Fri, 29 Oct 2021 20:19:02 GMT, John Hendrikx <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed javadoc
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/LabelSkinTest.java
> line 2162:
>
>> 2160: label.autosize();
>> 2161: skin.updateDisplayedText();
>> 2162: assertEquals("foo _bar _qux",
>> LabelSkinBaseShim.getText(label).getText());
>
> Can you verify here which letter / index is picked as mnemonic? (Also in the
> other tests).
I don't see an easy way to do that, and I'm not in favor of making private
implementation details package-public just to test some internal state. Of
course, mnemonic support should have been designed in a way that is more easily
testable, but this PR is not the place to do that.
-------------
PR: https://git.openjdk.java.net/jfx/pull/647
