On Sat, 30 Oct 2021 14:49:24 GMT, Michael Strauß <[email protected]> wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with four
> additional commits since the last revision:
>
> - revert rename
> - revert rename
> - test for KeyCombination
> - renamed TextBinding to MnemonicParser, refactored tests
modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/MnemonicParser.java
line 63:
> 61: * </ul>
> 62: */
> 63: public class MnemonicParser {
As mentioned in the comments, I prefer this rename to be reverted. It could be
done separately as cleanup.
modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/MnemonicParser.java
line 194:
> 192: } else if (isExtendedMnemonic(s, i)) {
> 193: mnemonic = String.valueOf(s.charAt(i + 2));
> 194: mnemonicIndex = i;
Good catch. This is needed to make extended mnemonics work.
-------------
PR: https://git.openjdk.java.net/jfx/pull/647
