On Fri, 8 Jul 2022 18:02:44 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Yes, the tests now all pass on my MacBook Pro which has a retina display. >> >>> I will merge with my latest marlin code asap = 0.9.4.6 (2 more bugs fixed), >>> low risk (few lines) if you agree. >> >> Yes, that would be fine. Let's change the titles of this PR and the JBS >> issue to reflect the .6 patch version. Also, can you merge in the latest >> upstream master? Your branch is very out of date. >> >> Since I am just starting the review, I'm not sure whether we will be able to >> get this in before the RDP1 deadline, so it will either just barely make >> JavaFX 19 (if right before RDP1) or it can be integrated early in JavaFX 20. > >> I will merge with my latest marlin code asap = 0.9.4.6 (2 more bugs fixed), >> low risk (few lines) if you agree. > > (but don't change your branch name or would need to create a new PR, which > doesn't seem worth it) Thanks @kevinrushforth for instructions. The dpqs part and stroker changes were released in marlin 0.9.4.5 publicly on my github... so it passed the production to me. If you have any question, please ask. Cheers, Laurent (covid+ since wednesday) ------------- PR: https://git.openjdk.org/jfx/pull/674
