On Tue, 19 Jul 2022 22:08:19 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> …ontract
> 
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect 
> statement "Is functionally equivalent to calling 
> <code>getSelectedIndices().contains(index)</code>." 
> 2. reimplement TableView.isSelected(int) method to return true when at least 
> one cell in *any* column is selected on the given row (was: *all* columns)
> 3. change selectRowWhenInSingleCellSelectionMode() and 
> selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest 
> to reflect new reality.
> 
> NOTE: proposed change alters semantics of isSelected(int) method (in the 
> right direction, in my opinion).

OK. When you create the CSR, you can add a note about possible compatibility 
impact. Seems it should be low.

@kleopatra Would you have time / interest to review this?

-------------

PR: https://git.openjdk.org/jfx/pull/839

Reply via email to