On Tue, 26 Jul 2022 16:00:15 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
> 1. javadoc for TableSelectionModel.isSelected(int, TablecolumnBase) > already describes the logic: Yes. I am aware of this documentation. I was thinking of making it clear for the users if they see their application breaks due to this change. I see that you have captured this in "Compatibility Impact" section of the CSR. > 2. TreeTableView.TreeTableViewSelectionModel extends TableSelectionModel, > so the changes affect both. I see that there are overridden methods `public boolean isSelected(int index)` and `public boolean isSelected(int row, TableColumnBase<TreeItem<S>,?> column)` in class `TreeTableViewArrayListSelectionModel` present in TreeTableView.java. Hence, I think that the change that you have made in `TableView.java - isSelected(int index)` method should also be made in `TreeTableView.java - isSelected(int index)` as well. > 3. good point, fixed. Thanks! ------------- PR: https://git.openjdk.org/jfx/pull/839
