> …ontract > > 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect > statement "Is functionally equivalent to calling > <code>getSelectedIndices().contains(index)</code>." > 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to > return true when at least one cell in *any* column is selected on the given > row (was: *all* columns) > 3. change selectRowWhenInSingleCellSelectionMode() and > selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest > to reflect new reality. > > NOTE: proposed change alters semantics of isSelected(int) method (in the > right direction, in my opinion).
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - 8235491: tree table view - Merge remote-tracking branch 'origin/master' into 8235491.isselected - 8235491: review comments - 8235491: whitespace - 8235491: javadoc - 8235491: 2022 - 8235491: Tree/TableView: implementation of isSelected(int) violates contract ------------- Changes: - all: https://git.openjdk.org/jfx/pull/839/files - new: https://git.openjdk.org/jfx/pull/839/files/fcdf223d..be4825ab Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=03 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=02-03 Stats: 7181 lines in 26 files changed: 462 ins; 6659 del; 60 mod Patch: https://git.openjdk.org/jfx/pull/839.diff Fetch: git fetch https://git.openjdk.org/jfx pull/839/head:pull/839 PR: https://git.openjdk.org/jfx/pull/839
