On Mon, 8 Aug 2022 21:51:05 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

> 
> I think you are right, @kleopatra ! Took me a while, but I see your point 
> now. This method should indeed delegate to super(), or not be overridden at 
> all.
> 

I would prefer removing it (reducing clutter :) As it's a private class, there 
will be no publicly visible change.

> Thank you for creating the tests - they deserve to be integrated into 
> TableViewSelectionModelImplTest, with your permission.

sure, everything here is open source and we don't want to duplicate efforts :) 

Probably need to do the same fix and test in TreeTableView selection?

-------------

PR: https://git.openjdk.org/jfx/pull/839

Reply via email to