On Thu, 4 Aug 2022 23:01:37 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > I did a quick skim of the DPQS class, enough to know that code review is > unlikely to spot the kind of subtle bugs that such code might have. So my > main question is around testing of DQPS itself. How much standalone testing > has been done on the sort algorithm? > > I did see that several of the methods are missing `@param` tags in the docs, > and while this isn't public API, it would aid understanding it a bit better > if those were added. > > I'm still wondering whether it should be enabled by default. On the one hand, > it would reduce risk to have it disabled by default. On the other hand, if we > enable it now, we are early enough in JavaFX 20 that if problems are found, > they can be fixed and/or it can be disabled by default later. @kevinrushforth I merged with master and made requested changes. It is ready for me. Could you have a look ? Thanks ------------- PR: https://git.openjdk.org/jfx/pull/674
