On Tue, 23 Aug 2022 11:37:38 GMT, Nir Lisker <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java
>> line 130:
>>
>>> 128: * will treat that duration as if it were Duration.ZERO. Likewise, any
>>> Duration which answers true
>>> 129: * to {@link javafx.util.Duration#isIndefinite()} will be treated as
>>> if it were a duration of Double.MAX_VALUE
>>> 130: * milliseconds. Any {@code null} Duration is treated as
>>> Duration.ZERO. Any custom implementation of a backoff strategy
>>
>> Since you changed `null` to use code style, maybe also do it for
>> `Duration.ZERO`?
>
> There are many places that are missing it in this class. Should I do them all
> while here?
I'll leave that up to you.
-------------
PR: https://git.openjdk.org/jfx/pull/880