On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Addressed review comments

Looks good with one optional suggestion.

modules/javafx.controls/src/main/java/javafx/scene/control/TextFormatter.java 
line 50:

> 48:  * setting a value will result in an {@code IllegalStateException} and 
> the value is always {@code null}.
> 49:  * <p>
> 50:  * Since {@code Formatter} contains a value which represents the state of 
> the {@code TextInputControl} to which it is

One more thing I noticed: "contains a value which" could be changed to 
"contains a value that"

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/880

Reply via email to