On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi <a...@openjdk.org> wrote:

>> LoongArch is a new RISC ISA. This issue proposes adding support for 
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but 
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit 
>> is updated to OpenJFX, it is supposed to work.
>> 
>> Testing:
>> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with 
>> WebKit,without Webkit} on Linux/x64
>> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with 
>> WebKit,without Webkit} on Linux/aarch64
>> - [x] base, controls, fxml and graphics tests, {Release,Debug}, without 
>> WebKit on Linux/loongarch64
>
> Ao Qi has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   revert

build.gradle line 313:

> 311: } else if (IS_MAC && OS_ARCH != "x86_64" && OS_ARCH != "aarch64") {
> 312:     fail("Unknown and unsupported build architecture: $OS_ARCH")
> 313: } else if (IS_LINUX && OS_ARCH != "i386" && OS_ARCH != "amd64" && 
> OS_ARCH != "aarch64" && OS_ARCH != "loongarch64") {

this could be simplified with 
`... && !IS_LOONGARCH64` which avoids the more error-prone duplicate 
"loongarch64" string.
(the same applies to replacing the aarch64 check with !IS_AARCH64)

-------------

PR: https://git.openjdk.org/jfx/pull/888

Reply via email to