On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi <a...@openjdk.org> wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to OpenJFX, it is supposed to work.
>>
>> Testing:
>> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with
>> WebKit,without Webkit} on Linux/x64
>> - [x] base, controls, fxml, graphics and web tests, {Release,Debug}, {with
>> WebKit,without Webkit} on Linux/aarch64
>> - [x] base, controls, fxml and graphics tests, {Release,Debug}, without
>> WebKit on Linux/loongarch64
>
> Ao Qi has updated the pull request incrementally with one additional commit
> since the last revision:
>
> revert
This PR looks safe to me. I don't see a scenario where this can cause
regression. I can't say if those changes are enough to build for LoongArch64
though, but as long as there is no regression I am ok.
There are a few minor optimizations that I suggested -- in general, there are
more places in the build.gradle file where we could benefit from optimizations
but I don't recommend doing that as part of this PR.
-------------
PR: https://git.openjdk.org/jfx/pull/888
