On Mon, 7 Nov 2022 13:11:27 GMT, Ambarish Rapte <[email protected]> wrote:
> This issue was uncovered when running the test added in PR: > https://github.com/openjdk/jfx/pull/924 > The JUnit5 tests using Params API fails to compile. > > Fix: > Change dependency of `junit-jupiter-params` from runtime to compile time. > From: > https://junit.org/junit5/docs/current/user-guide/#overview-what-is-junit-5: > it can be understood that packages of JUnit Jupiter other than `TestEngine` > are required for test compilation and > JUnit Platform serves as a foundation for [launching testing > frameworks](https://junit.org/junit5/docs/current/user-guide/#launcher-api) > > It seems that changing dependency of this one package is sufficient for this > fix. Looks good, pending my question about `junit-platform-commons`. build.gradle line 1995: > 1993: testRuntimeOnly group: "org.apiguardian", name: > "apiguardian-api", version: "1.1.2" > 1994: testRuntimeOnly group: "org.junit.jupiter", name: > "junit-jupiter-engine", version: "5.8.1" > 1995: testRuntimeOnly group: "org.junit.platform", name: > "junit-platform-commons", version: "1.8.1" Have you checked whether the `junit-platform-commons` jar file, which also has public JUnit5 API, needs the same treatment? I might recommend also moving that one to `testImplementation` as well. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/939
