On Mon, 7 Nov 2022 17:04:35 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add test
>
> modules/javafx.base/src/test/java/test/JUnit5Test.java line 49:
>
>> 47: static int callCount;
>> 48: static int[] intValues = {1, 2, 3};
>> 49: @ValueSource(ints = {1, 2, 3})
>
> Minor: maybe add a blank line before this line?
Added new line.
> modules/javafx.base/src/test/java/test/JUnit5Test.java line 68:
>
>> 66: if (i != 0) {
>> 67: fail("Test method not called for Value " + i);
>> 68: }
>
> Minor: could simplify this to:
>
>
> assertEquals(0, i, "Test method not called for Value " + i);
Changed the assert.
-------------
PR: https://git.openjdk.org/jfx/pull/939
