On Mon, 7 Nov 2022 13:31:50 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add test > > Looks good, pending my question about `junit-platform-commons`. @kevinrushforth Added a test as you suggested offline. The checks inside test may not be required, please suggest if any modifications required. > build.gradle line 1995: > >> 1993: testRuntimeOnly group: "org.apiguardian", name: >> "apiguardian-api", version: "1.1.2" >> 1994: testRuntimeOnly group: "org.junit.jupiter", name: >> "junit-jupiter-engine", version: "5.8.1" >> 1995: testRuntimeOnly group: "org.junit.platform", name: >> "junit-platform-commons", version: "1.8.1" > > Have you checked whether the `junit-platform-commons` jar file, which also > has public JUnit5 API, needs the same treatment? I might recommend also > moving that one to `testImplementation` as well. Hi Kevin, Thanks for the pointer. As we checked that the jupiter-platform classes are used for test framework development, a change for them is not required for now. ------------- PR: https://git.openjdk.org/jfx/pull/939
